RFR: 8286396: Address possibly lossy conversions in jdk.management.jfr [v2]

Erik Gahlin egahlin at openjdk.java.net
Wed May 11 11:29:29 UTC 2022


> Could I have a review of two lossy conversion issues.
> 
> The size of an event can't be larger than 2^28, so it shouldn't be an issue in practise, but the type id could potentially be larger than 2^31, but it would require a user to load more than 2 billion classes. 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into lossy_jdkmanagementjfr
 - Initial

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8603/files
  - new: https://git.openjdk.java.net/jdk/pull/8603/files/47329c10..bb498043

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8603&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8603&range=00-01

  Stats: 7706 lines in 219 files changed: 4221 ins; 2119 del; 1366 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8603.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8603/head:pull/8603

PR: https://git.openjdk.java.net/jdk/pull/8603


More information about the hotspot-jfr-dev mailing list