RFR: 8292266: Add JFR event for total Reference processing time
Thomas Schatzl
tschatzl at openjdk.org
Fri Nov 18 13:22:58 UTC 2022
On Fri, 18 Nov 2022 05:04:38 GMT, Sangheon Kim <sangheki at openjdk.org> wrote:
> Hi all,
>
> Can I have reviews for this change that adds a new JFR event for total Reference Processing time?
>
> The goal is to generate a new JFR event if there is already measured time. This CR doesn't add new time measurement.
>
> Testing: hs-tier1 ~ 3
>
> Thanks,
> Sangheon
Some minor comments in explanation texts/naming, but lgtm.
src/hotspot/share/jfr/metadata/metadata.xml line 393:
> 391: </Event>
> 392:
> 393: <Event name="GCReferenceProcessTime" category="Java Virtual Machine, GC, Reference" label="GC Reference Process Time" startTime="false"
Suggestion:
<Event name="GCReferenceProcessingTime" category="Java Virtual Machine, GC, Reference" label="GC Reference Processing Time" startTime="false"
src/hotspot/share/jfr/metadata/metadata.xml line 394:
> 392:
> 393: <Event name="GCReferenceProcessTime" category="Java Virtual Machine, GC, Reference" label="GC Reference Process Time" startTime="false"
> 394: description="Total processing time of processed references during GC">
Suggestion:
description="Total time for processing java.lang.ref.References during GC">
-------------
Marked as reviewed by tschatzl (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11230
More information about the hotspot-jfr-dev
mailing list