RFR: 8292266: Add JFR event for total Reference processing time [v5]

Sangheon Kim sangheki at openjdk.org
Tue Nov 22 07:21:40 UTC 2022


On Tue, 22 Nov 2022 02:08:48 GMT, Sangheon Kim <sangheki at openjdk.org> wrote:

>> Hi all,
>> 
>> Can I have reviews for this change that adds a new JFR event for total Reference Processing time?
>> 
>> The goal is to generate a new JFR event if there is already measured time. This CR doesn't add new time measurement.
>> 
>> Testing: hs-tier1 ~ 3
>> 
>> Thanks,
>> Sangheon
>
> Sangheon Kim has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add Shenandoah and Z. albertnetymk and egahlin comment.
>  - Revert to initial commit. Albert review.

1. Reverted to the first version which has separate GCTrace::report_gc_reference_processing_time().
2. Added Z and Shenandoah impl. 

For Z and Shenandoah, I understand your point. But this is why I explicitly mentioned on CR/PR that I intended to emit already measured TOTAL time via ReferenceProcessorStats class. i.e. not add something new.

Thanks @albertnetymk and @egahlin for your comments.

-------------

PR: https://git.openjdk.org/jdk/pull/11230


More information about the hotspot-jfr-dev mailing list