RFR: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize [v2]
Erik Gahlin
egahlin at openjdk.org
Tue Nov 22 11:15:57 UTC 2022
> Could I have a review of a PR that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream:
> https://github.com/openjdk/jdk/blob/b366d17a94e5b16710fd915ef4cf04aaf911b455/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java#L287
>
> I also fixed a problem where chunks may we written out of order in the dump file and disk chunks not being released properly in case of an IOException. To make the code easier to understand, the code uses more logical methods when interacting with the Deque , such as peekLast(), pollLast() and addFirst().
>
> Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Update
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11275/files
- new: https://git.openjdk.org/jdk/pull/11275/files/0244c851..ca9636d3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11275&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11275&range=00-01
Stats: 153 lines in 5 files changed: 139 ins; 1 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/11275.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11275/head:pull/11275
PR: https://git.openjdk.org/jdk/pull/11275
More information about the hotspot-jfr-dev
mailing list