RFR: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events [v2]
Joakim Nordström
jnordstrom at openjdk.org
Tue Oct 18 12:16:00 UTC 2022
On Fri, 14 Oct 2022 08:52:11 GMT, Joakim Nordström <jnordstrom at openjdk.org> wrote:
>> Changed the JFR chunk rotation lock object to specific internal class. This allows that specific Object.wait() event to be skipped, thus not adding JFR internal noise to recordings.
>>
>> # Testing
>> - jdk_jfr
>
> Joakim Nordström has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Changed name to CHUNK_ROTATION_MONITOR and made some other rearrangements
> - Changed name to CHUNK_ROTATION_MONITOR and made some other rearrangements
> - Merge branch 'master' into JDK-8286707-jfr-dont-commit-jfr-internal-jdk-javamonitorwait-events
> - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
> - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
> - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
> - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
Would it be possible to add this filtering as part of the throttling mechanism? I guess it would push the meaning of throttling, and might be overkill for this specific use-case, but perhaps some new internal throttle-like approach could be implemented?
I'll do some experimentation and see what I might come up with.
-------------
PR: https://git.openjdk.org/jdk/pull/8883
More information about the hotspot-jfr-dev
mailing list