RFR: 8293167: Memory leak in JfrThreadSampler if stackdepth is larger than default (64) [v2]
Markus Grönlund
mgronlun at openjdk.org
Fri Sep 2 16:49:58 UTC 2022
On Fri, 2 Sep 2022 16:04:01 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.cpp
>>
>> Co-authored-by: Jaroslav Bachorik <j.bachorik at gmail.com>
>
> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.cpp line 37:
>
>> 35: // The queue instances are used by the load barrier to enqueue tagged Klass'es.
>> 36: static JfrTraceIdKlassQueue* _klass_queue = nullptr; // Generic for all Java threads.
>> 37: static JfrTraceIdKlassQueue* _sampler_klass_queue = nullptr; // Specialized for the Jfr Thread Sampler using use a larger buffer size.
>
> Suggestion:
>
> static JfrTraceIdKlassQueue* _sampler_klass_queue = nullptr; // Specialized for the Jfr Thread Sampler using a larger buffer size.
Thanks @jbachorik for noticing.
-------------
PR: https://git.openjdk.org/jdk/pull/10129
More information about the hotspot-jfr-dev
mailing list