RFR: 8257967: JFR: Events for loaded agents [v16]

[Markus Grönlund]

On Wed, 12 Apr 2023 11:01:43 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renames
>
> src/hotspot/share/prims/jvmtiAgent.cpp line 357:
> 
>> 355:       vm_exit_during_initialization("Could not find JVM_OnLoad or Agent_OnLoad function in the library", name());
>> 356:     }
>> 357:     _xrun = false; // converted
> 
> Just questions to understand it better.
> Neither `JVM_Onload` nor `Agent_Onload` entry points are stored after these lookups. It means that in order to be called later (as the comment at line 350 says) they have to be looked up again.
> Is it right? Was it the same originally?

The entry points are not saved and so have to be looked up again. It was the same originally.

That is why there is a check and branch on agent->is_loaded().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12923#discussion_r1163979282