RFR: 8313141: Missing check for os_thread type in os_windows.cpp [v4]
David Holmes
dholmes at openjdk.org
Tue Aug 1 08:54:54 UTC 2023
On Tue, 1 Aug 2023 06:38:47 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Comment to explain
Minor nit on comment but otherwise fix looks good.
If there is any fallout from the change in behaviour we will deal with it then.
Thanks
src/hotspot/os/windows/os_windows.cpp line 721:
> 719: case os::asynclog_thread:
> 720: case os::watcher_thread:
> 721: default: // follow Unix and presume the unknown thread type is an internal VM one
No need for the "follow unix and".
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15079#pullrequestreview-1556480373
PR Review Comment: https://git.openjdk.org/jdk/pull/15079#discussion_r1280307240
More information about the hotspot-jfr-dev
mailing list