RFR: JDK-8313251: Add NativeLibraryLoad event [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Aug 2 10:36:55 UTC 2023


On Fri, 28 Jul 2023 13:09:56 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add macro guards because the build errors in zero build
>
> src/hotspot/os/bsd/os_bsd.cpp line 1027:
> 
>> 1025:   log_info(os)("attempting shared library load of %s", filename);
>> 1026: 
>> 1027: #if INCLUDE_JFR
> 
> We typically skip INCLUDE_JFR for events and rely on empty stubs in the code generation. This to make the code more easy to read.

Hi Erik , I removed the JFR with configure and attempted this (however on Linux) but for some reason I got build errors. So I better added the macros. (not sure why this happened, with some other JFR event living without INCLUDE_JFR seemed to  work as expected)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1281721182


More information about the hotspot-jfr-dev mailing list