RFR: JDK-8313251: Add NativeLibraryLoad event [v2]
Matthias Baesken
mbaesken at openjdk.org
Wed Aug 2 13:08:52 UTC 2023
On Wed, 2 Aug 2023 12:28:33 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Hi Erik, this was taken from test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java , I do not see in main there a try with resources. What do you want to put in the try block exactly ? The new Recording() ?
>
> Yes.
> try (Recording r = new Recording()) {
> ...
> }
> It's not used everywhere, but it seems proper to release chunk resources when the test is finished.
>
> (I should probably go over all tests and change to avoid the pattern being copied.)
HI Erik, I adjusted the test as recommended .
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1281878884
More information about the hotspot-jfr-dev
mailing list