RFR: JDK-8313251: Add NativeLibraryLoad event [v5]

[Matthias Baesken]

On Thu, 3 Aug 2023 07:16:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use try with resources in test
>
> test/jdk/jdk/jfr/event/runtime/TestNativeLibraryLoadEvent.java line 77:
> 
>> 75:             libTemplate = "%s.dll";
>> 76:         } else if (Platform.isOSX()) {
>> 77:             libTemplate = "lib%s.dylib";
> 
> We have `Platform.sharedLibraryExt()` to simplify this a bit. Unfortunately we don't have a `sharedLibraryPrefix()` to reduce it to one line. :(

Hi David,  that coding can indeed be improved. But let's do it in a follow-up.  And in the follow-up also for  existing https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java where the same/similar code is present. The follow-up should also introduce 'sharedLibraryPrefix'   .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1282770754