RFR: 8313722: JFR: Avoid unnecessary calls to Events.from(Recording)

Andrey Turbanov aturbanov at openjdk.org
Fri Aug 4 14:04:32 UTC 2023


On Fri, 4 Aug 2023 02:33:48 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of PR that removes unnecessary calls to Events.from(Recording). 
> 
> With each call a new dump file is created. A better approach is store the events in a List that can be reused,
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

test/jdk/jdk/jfr/event/runtime/TestSafepointEvents.java line 71:

> 69:         try {
> 70:             // Verify that each event type was seen at least once
> 71:             List<RecordedEvent> events =  Events.fromRecording(recording);

Suggestion:

            List<RecordedEvent> events = Events.fromRecording(recording);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15147#discussion_r1284463253


More information about the hotspot-jfr-dev mailing list