RFR: 8313552: Fix -Wconversion warnings in JFR code [v2]

Markus Grönlund mgronlun at openjdk.org
Fri Aug 4 18:02:58 UTC 2023


On Fri, 4 Aug 2023 15:09:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove compile flag
>>  - checked_cast
>
> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.hpp line 58:
> 
>> 56: 
>> 57:   template <typename T>
>> 58:   static void meta_clear(uint8_t bits, const T* ptr);
> 
> jbyte -> uint8_t is definitely preferable.

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15152#discussion_r1284703552


More information about the hotspot-jfr-dev mailing list