RFR: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs

Aleksey Shipilev shade at openjdk.org
Wed Aug 30 19:20:29 UTC 2023


On Mon, 28 Aug 2023 13:15:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug for example test failure. There are two ways to fix it: bring in `Whitebox` and sense the JVMCI support from there, or use the `@requires` to sense this and other conditions for JVMCI enablement then. `@requires` seems safer, so I did that one.
> 
> Additional testing:
>  - [x] Affected test with `-XX:+UseShenandoahGC` (now passes)
>  - [x] Affected test with `-XX:+UseParallelGC` (still passes)

Thanks for reviews. @egahlin, you modified this test a lot of times, are you good with this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15446#issuecomment-1699707355


More information about the hotspot-jfr-dev mailing list