RFR: 8211238: @Deprecated JFR event [v16]
Markus Grönlund
mgronlun at openjdk.org
Tue Dec 5 17:42:41 UTC 2023
On Tue, 5 Dec 2023 17:16:50 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update event description
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/Level.java line 41:
>
>> 39: * This settings is only supported for JVM events.
>> 40: *
>> 41: * @since 21
>
> Should this be `@since 22` ?
You are right. Thank you for spotting.
> src/jdk.jfr/share/classes/jdk/jfr/internal/test/DeprecatedMethods.java line 25:
>
>> 23: package jdk.jfr.internal.test;
>> 24:
>> 25: public class DeprecatedMethods {
>
> Is this class (and also `DeprecatedThing`) supposed to be in the source tree rather than the test tree?
They have to go into the source tree because we only report deprecated methods located in the JDK :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1416053762
PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1416054856
More information about the hotspot-jfr-dev
mailing list