RFR: 8294978: Convert 5 test/jdk/jdk/jfr tests from ASM library to Classfile API [v4]

Chen Liang liach at openjdk.org
Sun Dec 17 15:30:47 UTC 2023


On Sun, 17 Dec 2023 15:12:20 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Converted these tests to Classfile API and some of the constants to Constant API. InstrumentationCallback.callback wasn't changed to a record since I cannot figure out how to ship a nested record class with InstrumentationCallback in a jar.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Fix preview argument in in-code launcher
>  - Merge branch 'master' into 8294978
>  - Update to preview CF API
>  - Merge branch 'master' into 8294978
>  - Classfile object update
>  - Merge branch 'master' into 8294978
>  - Utilize newly added constants
>  - Merge branch 'master' into 8294978
>  - Convert jdk.jfr tests to ASM

@egahlin I am requesting a review for this patch which migrates ASM occurrences in JFR tests to the Class-File API, after JFR's own code's migration in #16195.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13072#issuecomment-1859202172


More information about the hotspot-jfr-dev mailing list