RFR: 8275338: Add JFR events for notable serialization situations [v3]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Dec 19 12:21:09 UTC 2023


On Tue, 19 Dec 2023 10:43:57 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Event enabled on profile.jfc but disabled on default.jfc.
>
> src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java line 48:
> 
>> 46: 
>> 47:     @Label("Kind")
>> 48:     public int kind;
> 
> What is the use case for error codes? Are they public or an implementation detail?

The intent is that they are stable and for programmatic usage, whereas the message is more for human consumption. The codes are used in the test, for example, and are declared as public static in the event classes.

Alternatively, one could parse the message, but that's less robust in face of changes, I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431329983


More information about the hotspot-jfr-dev mailing list