RFR: 8275338: Add JFR events for notable serialization situations [v5]
    Roger Riggs 
    rriggs at openjdk.org
       
    Wed Dec 20 14:24:51 UTC 2023
    
    
  
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changes according to reviewer's comments.
src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java line 113:
> 111:             if (longFromStatic(f) == null) {
> 112:                 commitEvent(SUID_CONVERTIBLE_TO_LONG,
> 113:                         SUID_NAME + " must be convertible to long via widening to be effective");
The serialization spec only shows using long.  If any recommendation is made it should be to declare the field as a `long`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1432778556
    
    
More information about the hotspot-jfr-dev
mailing list