Integrated: 8288783: Error messages are confusing when options conflict in -XX:StartFlightRecording

[Chihiro Ito]

On Tue, 28 Jun 2022 05:50:38 GMT, Chihiro Ito <cito at openjdk.org> wrote:

> Could I have a review of PR that fixes incorrect error messages regarding of recording.
> 
> The current message is very confusing. If a user types jcmd <pid> JFR.start name=abc name=def or java --XX:StartFlightRecording=name=abc,name=def,  the error message says "Duplicates in diagnostic command arguments", but doesn't know what options are duplicated.
> Furthermore, if a user specifies two or three duplicate parameters, the same logs will be output.
> 
> It should say follows,
> Option name can only be specified once with starting flight recording
> Options name and disk can only be specified once with starting flight recording
> Options name, disk and maxage can only be specified once with starting flight recording
> This problem affects --XX:StartFlightRecording, jcmd JFR.start, JFR.stop, JFR.dump, JFR.check, and MBean.
> 
> For other than start, the output is as follows, (example of dump)
> Option name can only be specified once with dumping flight recording
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Chihiro

This pull request has now been integrated.

Changeset: 36478ee1
Author:    Chihiro Ito <cito at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/36478ee13f0877447852470150c01397388b3f82
Stats:     138 lines in 3 files changed: 135 ins; 1 del; 2 mod

8288783: Error messages are confusing when options conflict in -XX:StartFlightRecording

Reviewed-by: egahlin

-------------

PR: https://git.openjdk.org/jdk/pull/9302