RFR: JDK-8300783: Consolidate byteswap implementations [v13]

Justin King jcking at openjdk.org
Fri Feb 17 14:19:20 UTC 2023


On Fri, 17 Feb 2023 05:38:41 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Out of curiosity, why `reverse_bits.hpp` instead of `reverseBits.hpp`? I have seen a few files in `utilities/` use the former, but the rest of Hotspot seems to always use the later? Is it because they contain a single function?
>> 
>> I went with `reverse_bits.hpp` for now as suggested for consistency with the other bit fiddling headers in `utilities/`.
>
> The usual camel-case with lowercase start convention typically refers to a class name in the file.
> I'm not sure snake-case for files with a single function was a good idea, even though it might have
> been my fault.  But it's what we're doing (at least for now).

Works for me, just want to make sure I am consistent with the rest.

-------------

PR: https://git.openjdk.org/jdk/pull/12114


More information about the hotspot-jfr-dev mailing list