RFR: 8302858: Polish FlightRecorderMXBeanImpl

Kevin Walls kevinw at openjdk.org
Mon Feb 20 15:07:26 UTC 2023


On Mon, 20 Feb 2023 10:51:29 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes some polishing of the `FlightRecorderMXBeanImpl` class.

src/jdk.management.jfr/share/classes/jdk/management/jfr/FlightRecorderMXBeanImpl.java line 305:

> 303:         validateOption(ops, OPTION_DESTINATION, x -> MBeanUtils.destination(r, x));
> 304: 
> 305:         // All OK, now set them.atomically

As this is a tidyup, could we remove the dot from "them.atomically" which is a typo.
I didn't see what was atomic at first.  If all options are valid, we set them all, which is great, but not really atomic.  Could just remove the word "atomically"?

-------------

PR: https://git.openjdk.org/jdk/pull/12656


More information about the hotspot-jfr-dev mailing list