RFR: 8302858: Polish FlightRecorderMXBeanImpl [v2]

Per Minborg pminborg at openjdk.org
Mon Feb 20 17:16:55 UTC 2023


On Mon, 20 Feb 2023 16:43:32 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove typo
>>  - Rollback value check
>
> src/jdk.management.jfr/share/classes/jdk/management/jfr/FlightRecorderMXBeanImpl.java line 286:
> 
>> 284:             Object value = entry.getValue();
>> 285:             if (!(key instanceof String)) {
>> 286:                 throw new IllegalArgumentException("Option key must not be null, or other type than " + String.class);
> 
> Why is the type check removed?

Because it must be a String as we are iterating over Map.Entry<String, String>

-------------

PR: https://git.openjdk.org/jdk/pull/12656


More information about the hotspot-jfr-dev mailing list