RFR: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access [v2]

[Markus Grönlund]

On Thu, 12 Jan 2023 16:35:08 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/share/jfr/jni/jfrJavaSupport.cpp line 489:
> 
>> 487: 
>> 488: void JfrJavaSupport::get_field_local_ref(JfrJavaArguments* args, TRAPS) {
>> 489:   get_field_ref(args, true, THREAD);
> 
> I'd suggest add a comment for the bool arg like the following:
> `get_field_ref(args, true /* local_ref */, THREAD);`

Thanks, fixed.

> src/hotspot/share/jfr/jni/jfrJavaSupport.cpp line 493:
> 
>> 491: 
>> 492: void JfrJavaSupport::get_field_global_ref(JfrJavaArguments* args, TRAPS) {
>> 493:   get_field_ref(args, false, THREAD);
> 
> Same suggestion as above:
> `get_field_ref(args, false /* local_ref */, THREAD);`

Thanks. Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/11950