RFR: JDK-8300042: Improve CPU related JFR events descriptions [v2]

Christoph Langer clanger at openjdk.org
Wed Jan 18 22:10:31 UTC 2023


On Tue, 17 Jan 2023 12:47:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> There are a number of JFR events dealing with CPU related information. Those sometimes miss descriptions or have very limited descriptions, this can be improved.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust CPULoad description

I've got 3 further comments to shorten the description texts.

src/hotspot/share/jfr/metadata/metadata.xml line 793:

> 791: 
> 792:   <Event name="CPUInformation" category="Operating System, Processor" label="CPU Information"
> 793:          description="Various characteristics and descriptions of the processor(s) the JVM is running on"

I would leave out the word "Various" here

src/hotspot/share/jfr/metadata/metadata.xml line 803:

> 801: 
> 802:   <Event name="CPUTimeStampCounter" category="Operating System, Processor" label="CPU Time Stamp Counter"
> 803:          description="Various information about the CPU time stamp mechanism / (RD)TSC"

Same here, drop the "Various"

src/hotspot/share/jfr/metadata/metadata.xml line 812:

> 810: 
> 811:   <Event name="CPULoad" category="Operating System, Processor" label="CPU Load"
> 812:          description="Contains information about the recent CPU usage of the JVM process"

Here only say "Information about...", leave out the "Contains"

-------------

Changes requested by clanger (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11969


More information about the hotspot-jfr-dev mailing list