RFR: JDK-8300783: Consolidate byteswap implementations [v10]

Justin King jcking at openjdk.org
Wed Jan 25 15:58:53 UTC 2023


> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.

Justin King has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into byteswap
 - Be restrict on requiring 1, 2, 4, or 8 byte integers
   
   Signed-off-by: Justin King <jcking at google.com>
 - Consolidate more byteswap implementations and upgrade bit reversal
   
   Signed-off-by: Justin King <jcking at google.com>
 - Update comment
   
   Signed-off-by: Justin King <jcking at google.com>
 - Add missing static_cast to XL C/C++ implementation
   
   Signed-off-by: Justin King <jcking at google.com>
 - Cleanup Bytes::swap_uN
   
   Signed-off-by: Justin King <jcking at google.com>
 - Add XL C/C++ builtins
   
   Signed-off-by: Justin King <jcking at google.com>
 - Fix mistake in MSVC implementation
   
   Signed-off-by: Justin King <jcking at google.com>
 - Update comment to reflect previous commit change
   
   Signed-off-by: Justin King <jcking at google.com>
 - Use __bulitin_bswap for GCC in debug builds
   
   Signed-off-by: Justin King <jcking at google.com>
 - ... and 6 more: https://git.openjdk.org/jdk/compare/051995b8...3b9decfa

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12114/files
  - new: https://git.openjdk.org/jdk/pull/12114/files/56e5c235..3b9decfa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=08-09

  Stats: 22873 lines in 944 files changed: 9818 ins; 3924 del; 9131 mod
  Patch: https://git.openjdk.org/jdk/pull/12114.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114

PR: https://git.openjdk.org/jdk/pull/12114


More information about the hotspot-jfr-dev mailing list