RFR: JDK-8300783: Consolidate byteswap implementations [v12]
David Holmes
dholmes at openjdk.org
Tue Jan 31 01:08:01 UTC 2023
On Fri, 27 Jan 2023 17:00:58 GMT, Justin King <jcking at openjdk.org> wrote:
>> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.
>
> Justin King has updated the pull request incrementally with four additional commits since the last revision:
>
> - Update copyright
>
> Signed-off-by: Justin King <jcking at google.com>
> - Add missing include
>
> Signed-off-by: Justin King <jcking at google.com>
> - Remove unused include
>
> Signed-off-by: Justin King <jcking at google.com>
> - Reorganize tests
>
> Signed-off-by: Justin King <jcking at google.com>
Updates are fine - thanks.
I'll try to get someone to properly review this.
test/hotspot/gtest/utilities/test_byteswap.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
As a new file this should only have 2023 copyright year - thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/12114
More information about the hotspot-jfr-dev
mailing list