Integrated: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
Erik Gahlin
egahlin at openjdk.org
Wed Jul 26 10:51:03 UTC 2023
On Tue, 25 Jul 2023 19:28:50 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a test fix?
>
> The test creates a ChainNode object and adds 100 byte arrays to it. Then a long linked list of ChainNodes are created so the byte arrays are at the end. The test then tries to verify that there are at least one old object sample of type byte[] and that the reference chain back to the GC root is not too long.
>
> Problem is, there is no old object samples of type byte[], only those of type jdk.jfr.event.oldobject.TestHeapDeep$ChainNode. Fix is to loop until we found a sample and then verify the chain.
>
> Testing: 100 * test/jdk/jdk/jfr/event/oldobject/TestHeapDeap.java
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: c22cadf3
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c22cadf32fbfa206f089c9d73c3b7f3db069d47a
Stats: 15 lines in 1 file changed: 3 ins; 0 del; 12 mod
8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.org/jdk/pull/15026
More information about the hotspot-jfr-dev
mailing list