RFR: JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE

Thomas Stuefe stuefe at openjdk.org
Wed Jun 7 09:48:54 UTC 2023


On Tue, 6 Jun 2023 19:08:11 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

> Please review this simple fix to JDK-8309550.
> 
> NB: The problem originally reported only concerned `src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java`, but since this code was duplicated in `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` with, as far as I understood from the bug description, with an intent to refactor it a a later time, I opted to change both occurrences of the method.

Also, please enable Github actions in your repository (somewhere in settings). That way we see GHA tests here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14341#issuecomment-1580322139


More information about the hotspot-jfr-dev mailing list