RFR: JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2]

Frederic Thevenet fthevenet at openjdk.org
Wed Jun 7 10:07:18 UTC 2023


> Please review this simple fix to JDK-8309550.
> 
> NB: The problem originally reported only concerned `src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java`, but since this code was duplicated in `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` with, as far as I understood from the bug description, with an intent to refactor it a a later time, I opted to change both occurrences of the method.

Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:

  Put brackets around the ? condition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14341/files
  - new: https://git.openjdk.org/jdk/pull/14341/files/dca5b72c..2881a213

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14341&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14341&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/14341.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14341/head:pull/14341

PR: https://git.openjdk.org/jdk/pull/14341


More information about the hotspot-jfr-dev mailing list