RFR: 8304835 jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"

[Aleksey Shipilev]

On Wed, 14 Jun 2023 12:47:57 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a test fix?
> 
> The test fails intermittently because it's hard to guarantee that an object is being sampled. Fix is to repeat until one is found.
> 
> Testing: jdk/jdk/event/oldObject/TestArrayInformation.java
> 
> Thanks
> Erik

Apart from a stylistic nit below, looks fine.

Merge from master to get Windows GHA builds, and thus Windows GHA tests fixed.

test/jdk/jdk/jfr/event/oldobject/TestArrayInformation.java line 64:

> 62:                 recording.start();
> 63:                 for(int i = 0; i < 25; i++) {
> 64:                   leak.add( buildNestedArray(CHAIN_DEPTH));

Suggestion:

                for (int i = 0; i < 25; i++) {
                  leak.add(buildNestedArray(CHAIN_DEPTH));

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14467#pullrequestreview-1479537371
PR Comment: https://git.openjdk.org/jdk/pull/14467#issuecomment-1591271995
PR Review Comment: https://git.openjdk.org/jdk/pull/14467#discussion_r1229673508