RFR: JDK-8300783: Consolidate byteswap implementations [v14]

Vladimir Kozlov kvn at openjdk.org
Thu Mar 9 06:32:30 UTC 2023


On Wed, 15 Feb 2023 15:39:14 GMT, Justin King <jcking at openjdk.org> wrote:

>> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.
>
> Justin King has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 24 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into byteswap
>  - Update based on review
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Fix copyright
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Update copyright
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Add missing include
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Remove unused include
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Reorganize tests
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Fix test
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Merge remote-tracking branch 'upstream/master' into byteswap
>  - Be restrict on requiring 1, 2, 4, or 8 byte integers
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - ... and 14 more: https://git.openjdk.org/jdk/compare/fa0103ad...223d733b

This looks good to me. I will run testing for latest version before approval.

-------------

PR: https://git.openjdk.org/jdk/pull/12114


More information about the hotspot-jfr-dev mailing list