RFR: 8303229: JFR: Preserve disk repository after exit [v5]

Andrey Turbanov aturbanov at openjdk.org
Mon Mar 27 08:09:37 UTC 2023


On Thu, 23 Mar 2023 13:49:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Typo

test/jdk/jdk/jfr/startupargs/TestPreserveRepository.java line 43:

> 41: 
> 42:     public static void main(String... args) throws Exception {
> 43:         Path path  = Path.of("./preserved");

nit
Suggestion:

        Path path = Path.of("./preserved");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1148937113


More information about the hotspot-jfr-dev mailing list