RFR: 8319374: JFR: Remove instrumentation for exception events [v2]
Erik Gahlin
egahlin at openjdk.org
Tue Nov 7 10:39:31 UTC 2023
On Tue, 7 Nov 2023 09:24:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove SecurityException and IllegalArgumentException from throws clause
>
> src/java.base/share/classes/java/lang/Throwable.java line 125:
>
>> 123: * Flag that determines if exceptions should be traced by JFR
>> 124: */
>> 125: static volatile boolean tracing;
>
> The use-sites in Error check Throwable.tracing so not immediately obvious that it's JFR tracing. Maybe it should be renamed to jfrTracing or an accessor of that name added so it's a bit clearer at the use-sites.
Will change
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1384714812
More information about the hotspot-jfr-dev
mailing list