RFR: 8314745: JFR: @StackFilter

[Alan Bateman]

On Sun, 19 Nov 2023 18:53:47 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of change that allows stack frames to be filtered out.
> 
> For now, that mechanism is only available for JDK events, but plan is to make the annotation public once we feel confident the API is correct.
> 
> Testing: tier1 + tier2 + jdk/jdk/jfr/
> 
> Thanks
> Erik

I wonder about how maintainable this is. I assume it would be easy for the code to be refactored and the frames listed in the StackFilter annotation value to get out of date. Are there any options to put an annotation on the methods to be filtered, kinda like what we do with `@Hidden`? I realise this might restrict it to JDK events in java.base initially but it seems more maintainable that having event having a method list that isn't checkable at compile time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16726#issuecomment-1818464928