RFR: 8310994: Add JFR event for selection operations

[Tim Prinzing]

On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

> Added mirror event with static methods: jdk.internal.event.SelectionEvent that provides the duration of select calls and the count of how many keys are available.
> 
> Emit the event from SelectorImpl::lockAndDoSelect
> 
> Test at jdk.jfr.event.io.TestSelectionEvents

Yes, in JDKEvents this is the list:

private static final Class<?>[] instrumentationClasses = new Class<?>[] {
    FileInputStreamInstrumentor.class,
    FileOutputStreamInstrumentor.class,
    RandomAccessFileInstrumentor.class,
    FileChannelImplInstrumentor.class
};


On Tue, Nov 28, 2023 at 2:43 PM Alan Bateman ***@***.***>
wrote:

> Isn't this a replacement for the existing instrumentation? If these are
> new events I am sorry.
>
> It's a new event.
>
> What is keeping us from removing ASM in that case?
>
> I think file I/O, there is still instrumentation used for FileInputStream,
> FileOutputStream, RandomAccessFile and nio.FileChannel.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/16710#issuecomment-1830703533>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWJ25UH2YJZFS5RQLAIXAH3YGZEHZAVCNFSM6AAAAAA7QBCIFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQG4YDGNJTGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16710#issuecomment-1830842223