RFR: 8317951: Refactor loading of zip library to help resolve JDK-8315220 [v3]

[David Holmes]

On Thu, 19 Oct 2023 13:29:29 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This refactorization resolves the problem associated with [JDK-8315220](https://bugs.openjdk.org/browse/JDK-8315220) and, subsequently, [JDK-8315892](https://bugs.openjdk.org/browse/JDK-8315892).
>> 
>> Testing: jdk_jfr, tier1-9, stress testing
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   do not exit vm from HeapCompression usage

Changes requested by dholmes (Reviewer).

src/hotspot/share/utilities/zipLibrary.cpp line 65:

> 63:   assert(_zip_handle != nullptr, "invariant");
> 64:   void* func = os::dll_lookup(_zip_handle, name);
> 65:   if (func == nullptr && vm_exit_on_failure) {

This seems to be unraveling somewhat. If we don't exit-on-failure then the callers have to be prepared for that failure and it isn't obvious to me that is always the case. And this is no longer just a refactoring. So I think a separate issue would need to be filed to look at this change in behaviour.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16149#pullrequestreview-1689317224
PR Review Comment: https://git.openjdk.org/jdk/pull/16149#discussion_r1366524172