RFR: 8317562: [JFR] Compilation queue statistics [v2]

[Mat Carter]

If there are no concerns with the JFR event, it’s initial settings or the test, given that the small compiler changes have already been reviewed would someone be kind enough to review and sponsor the commit

Thanks in advance
Mat

From: hotspot-jfr-dev <hotspot-jfr-dev-retn at openjdk.org> on behalf of Mat Carter <macarte at openjdk.org>
Date: Wednesday, October 18, 2023 at 11:12 AM
To: hotspot-dev at openjdk.org <hotspot-dev at openjdk.org>, hotspot-jfr-dev at openjdk.org <hotspot-jfr-dev at openjdk.org>
Subject: Re: RFR: 8317562: [JFR] Compilation queue statistics [v2]
On Wed, 18 Oct 2023 17:35:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   fixed return type and changed NULL to nullptr
>
> src/hotspot/share/compiler/compileBroker.cpp line 530:
>
>> 528:   return _c2_compile_queue;
>> 529: }
>> 530:
>
> Note, `*_compiler_queue` could be `nullptr` if VM is build without C2 or C1 or when run with `-XX:-TieredCompilation` (only C2 is used) or with `-XX:TierdStopAtLevel={1,2,3}` (only C1 is used).
>
> Make sure you check it in JFR event.

Thank you!  The JFR event does check for NULL (now nullptr)

-------------

PR Review Comment: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.org%2Fjdk%2Fpull%2F16211%23discussion_r1364317003&data=05%7C01%7Cmatthew.carter%40microsoft.com%7C4c80af72893e4fb6326408dbd005cf39%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638332495614878626%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5wvfj1sZg3QJyoivoKGyz7xD3gO1lG3wRhuqFpt7sJY%3D&reserved=0<https://git.openjdk.org/jdk/pull/16211#discussion_r1364317003>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-jfr-dev/attachments/20231023/b16506f0/attachment-0001.htm>