RFR: 8294978: Convert 5 test/jdk/jdk/jfr tests from ASM library to Classfile API [v3]
Adam Sotona
asotona at openjdk.org
Thu Sep 21 19:03:21 UTC 2023
On Wed, 28 Jun 2023 07:08:42 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Converted these tests to Classfile API and some of the constants to Constant API. InstrumentationCallback.callback wasn't changed to a record since I cannot figure out how to ship a nested record class with InstrumentationCallback in a jar.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Classfile object update
> - Merge branch 'master' into 8294978
> - Utilize newly added constants
> - Merge branch 'master' into 8294978
> - Convert jdk.jfr tests to ASM
It look good, thanks for the contribution.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13072#pullrequestreview-1638519949
More information about the hotspot-jfr-dev
mailing list