RFR: 8330064: JFR: Incorrect function declarations for register/unregister_stack_filter

David Holmes dholmes at openjdk.org
Thu Apr 11 01:03:05 UTC 2024


The commit from [JDK-8314745](https://bugs.openjdk.org/browse/JDK-8314745) contains

jlong JNICALL jfr_register_stack_filter(JNIEnv* env, jobject classes, jobject methods);
jlong JNICALL jfr_unregister_stack_filter(JNIEnv* env, jlong start_filter_id);

in `jfrJniMethod.hpp`, but the definitions have different signatures:

JVM_ENTRY_NO_ENV(jlong, jfr_register_stack_filter(JNIEnv* env, jclass jvm, jobjectArray classes, jobjectArray methods))
  return JfrStackFilterRegistry::add(classes, methods, thread);
JVM_END

JVM_ENTRY_NO_ENV(void, jfr_unregister_stack_filter(JNIEnv* env, jclass jvm, jlong id))
  JfrStackFilterRegistry::remove(id);
JVM_END


This fixes the declarations to match the definitions.

The issue was detected attempting a 32-bit Windows built. Unclear why our main toolchains have not complained about this.

Testing: 
  - tiers 1-3 (sanity)
  - GHA

-------------

Commit messages:
 - 8330064: JFR: Incorrect function declarations for register/unregister_stack_filter

Changes: https://git.openjdk.org/jdk/pull/18733/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18733&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330064
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18733.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18733/head:pull/18733

PR: https://git.openjdk.org/jdk/pull/18733


More information about the hotspot-jfr-dev mailing list