RFR: 8326012: JFR: Event for time to safepoint [v9]

Denghui Dong ddong at openjdk.org
Thu Apr 11 07:51:34 UTC 2024


On Thu, 11 Apr 2024 07:29:18 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   delete _entries when disabled
>
> src/hotspot/share/jfr/support/jfrTimeToSafepoint.inline.hpp line 32:
> 
>> 30: 
>> 31: #include "runtime/safepoint.hpp"
>> 32: #include "runtime/vmThread.hpp"
> 
> Suggestion:
> 
> #include "jfr/support/jfrTimeToSafepoint.hpp"
> 
> #include "jfr/jfrEvents.hpp"
> #include "jfr/recorder/jfrEventSetting.inline.hpp"
> #include "runtime/safepoint.hpp"
> #include "runtime/vmThread.hpp"

Updated.

> src/hotspot/share/runtime/safepoint.cpp line 74:
> 
>> 72: #include "utilities/systemMemoryBarrier.hpp"
>> 73: 
>> 74: #if INCLUDE_JFR
> 
> Blankline at 73 should be removed

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17888#discussion_r1560587873
PR Review Comment: https://git.openjdk.org/jdk/pull/17888#discussion_r1560587955


More information about the hotspot-jfr-dev mailing list