RFR: 8330053: JFR: Use LocalDateTime instead ZonedDateTime
Leonid Mesnik
lmesnik at openjdk.org
Thu Apr 11 17:55:41 UTC 2024
On Wed, 10 Apr 2024 17:50:52 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of PR that changes so LocalDateTime instead of ZonedDateTime is used when naming chunk files. Problem is that a java.time.DateTimeException occurs when ZonedDateTime.now() is used and the time zone is invalid. This happens in a JCK test.
>
> It would be possible to catch the exception and fallback to LocalDateTime, but it seems better to have filenames that can't be manipulated if an application calls TimeZone::setDefault. That said, if there is a good argument to use a fallback and not always the default time zone, please let me know.
>
> Testing: jdk/jdk/jfr + applicable test in JCK.
>
> Thanks
> Erik
Please update copyrights.
-------------
Marked as reviewed by lmesnik (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18729#pullrequestreview-1994827488
More information about the hotspot-jfr-dev
mailing list