RFR: 8330053: JFR: Use LocalDateTime instead ZonedDateTime [v2]

Leonid Mesnik lmesnik at openjdk.org
Thu Apr 11 22:51:41 UTC 2024


On Thu, 11 Apr 2024 18:29:54 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of PR that changes so LocalDateTime instead of ZonedDateTime is used when naming chunk files. Problem is that a java.time.DateTimeException occurs when ZonedDateTime.now() is used and the time zone is invalid. This happens in a JCK test.
>> 
>> It would be possible to catch the exception and fallback to LocalDateTime, but it seems better to have filenames that can't be manipulated if an application calls TimeZone::setDefault. That said, if there is a good argument to use a fallback and not always the default time zone, please let me know.
>> 
>> Testing: jdk/jdk/jfr + applicable test in JCK.
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright

Sorry, the failure didn't reproduce first. Really, the problem still exist and LocaleDateTime use same functionality. See bug for more info.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18729#issuecomment-2050679514


More information about the hotspot-jfr-dev mailing list