RFR: 8329995: Restricted access to `/proc` can cause JFR initialization to crash [v2]

Jaroslav Bachorik jbachorik at openjdk.org
Mon Apr 15 13:21:01 UTC 2024


On Mon, 15 Apr 2024 08:59:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add explanatory comment
>
> This change doesn't seem sufficient as many of the ProcessIterator functions access something under /proc without checking is_valid. Is it just  direct access to /proc that fails rather than specific entries?

@dholmes-ora  The other places are either checking for `null` result or for error code. I re-checked them and they are not vulnerable to this problem. I agree that the access might be more consistent but I didn't want to introduce any large sweeping changes just for the sakes of the changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18775#issuecomment-2056834965


More information about the hotspot-jfr-dev mailing list