RFR: 8339191: JFR ChunkInputStream supports bulk read
David Schlosnagle
duke at openjdk.org
Wed Aug 28 19:43:49 UTC 2024
I would like to contribute an improvement to reading JFR recordings via `InputStream` by implementing `InputStream#read(byte[], int, int)` in `ChunkInputStream` to support bulk reads and avoid many expensive single byte `read()`.
Testing: `test/jdk/jdk/jfr/api/consumer/TestChunkInputStreamBulkRead.java`, `jdk_jfr`
While looking through some JFRs recently, I noticed some significant time spent in `java.io.BufferedInputStream#getBufIfOpen()` that traced back to transferring (via `InputStream#transferTo(OutputStream)` JFR profile recording being read via `InputStream` returned by `jdk.jfr.Recording#getStream(Instant , Instant)`. What caught my eye were calls to single byte `jdk.jfr.internal.ChunkInputStream#read()` rather than `read(byte[], int, int)` as seen in the stacktrace from JFR.
<img width="776" alt="image" src="https://github.com/user-attachments/assets/b92398cd-2761-4600-8cfe-ea1bada6efd2">
-------------
Commit messages:
- JFR ChunkInputStream supports bulk read
Changes: https://git.openjdk.org/jdk/pull/20534/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20534&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8339191
Stats: 123 lines in 2 files changed: 116 ins; 3 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/20534.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20534/head:pull/20534
PR: https://git.openjdk.org/jdk/pull/20534
More information about the hotspot-jfr-dev
mailing list