RFR: 8339191: JFR: Bulk read support for ChunkInputStream
David Schlosnagle
duke at openjdk.org
Thu Aug 29 18:14:18 UTC 2024
On Sat, 10 Aug 2024 21:55:29 GMT, David Schlosnagle <duke at openjdk.org> wrote:
> I would like to contribute an improvement to reading JFR recordings via `InputStream` by implementing `InputStream#read(byte[], int, int)` in `ChunkInputStream` to support bulk reads and avoid many expensive single byte `read()`.
>
> Testing: `test/jdk/jdk/jfr/api/consumer/TestChunkInputStreamBulkRead.java`, `jdk_jfr`
>
> While looking through some JFRs recently, I noticed some significant time spent in `java.io.BufferedInputStream#getBufIfOpen()` that traced back to transferring (via `InputStream#transferTo(OutputStream)` JFR profile recording being read via `InputStream` returned by `jdk.jfr.Recording#getStream(Instant , Instant)`. What caught my eye were calls to single byte `jdk.jfr.internal.ChunkInputStream#read()` rather than `read(byte[], int, int)` as seen in the stacktrace from JFR.
>
> <img width="776" alt="image" src="https://github.com/user-attachments/assets/b92398cd-2761-4600-8cfe-ea1bada6efd2">
Thanks for the review, will update shortly
-------------
PR Review: https://git.openjdk.org/jdk/pull/20534#pullrequestreview-2269732502
More information about the hotspot-jfr-dev
mailing list