RFR: 8310996: Add JFR event for connect operations [v6]

Alan Bateman alanb at openjdk.org
Tue Dec 3 17:11:49 UTC 2024


On Tue, 3 Dec 2024 15:12:10 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   split socket connect failure out to its own event.
>
> src/jdk.jfr/share/conf/jfr/default.jfc line 746:
> 
>> 744:       <setting name="enabled">true</setting>
>> 745:       <setting name="stackTrace">true</setting>
>> 746:       <setting name="threshold" control="socket-threshold">20 ms</setting>
> 
> Does this event needs a threshold?

I think it needs to be a duration event, otherwise it's possible to a floor events when connections fail immediately. With the current proposal then it is at least configurable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21528#discussion_r1868102788


More information about the hotspot-jfr-dev mailing list