RFR: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata

[Nizar Benalla]

On Wed, 4 Dec 2024 15:27:23 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that adds missing javadoc for the RecordingStream::onMetadata.
> 
> Testing: tier1 + test/jdk/jdk/jfr
> 
> Thanks
> Erik

Marked as reviewed by nbenalla (Committer).

Small change request, copyright in `src/jdk.jfr/share/classes/jdk/jfr/consumer/snippet-files/Snippets.java` need to be `2024`

Looks good to me.

[Without this javadoc](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8343780/api/jdk.jfr/jdk/jfr/consumer/RecordingStream.html#onMetadata(java.util.function.Consumer)), the example in the snippet and the text would use `EventStream` instead of `RecordingStream`.
I compiled the snippet and it is valid.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22547#pullrequestreview-2479928093
Changes requested by nbenalla (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22547#pullrequestreview-2479932001
PR Comment: https://git.openjdk.org/jdk/pull/22547#issuecomment-2518582337