RFR: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types

Erik Gahlin egahlin at openjdk.org
Thu Dec 12 13:37:05 UTC 2024


Could I have a review of PR that improves the query language for 'jfr view' so it can handle a wildcard with multiple event types, e.g. "SELECT * FROM E1, E2".

Every field has an index which corresponds to where it is located in resultFields array. Today, the same index can appear multiple times. See FieldBuilder::createWildcardField how this can happen when there are multiple event/filter types. The fix is to set the index after all fields have been added. 

Testing: jdk/jdk/jfr + manual check

Thanks
Erik

-------------

Commit messages:
 - Initial

Changes: https://git.openjdk.org/jdk/pull/22711/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22711&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8346099
  Stats: 10 lines in 2 files changed: 8 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22711.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22711/head:pull/22711

PR: https://git.openjdk.org/jdk/pull/22711


More information about the hotspot-jfr-dev mailing list