RFR: 8322142: JFR: Periodic tasks aren't orphaned between recordings

Carter Kozak duke at openjdk.org
Wed Jan 3 15:33:56 UTC 2024


On Tue, 2 Jan 2024 20:39:41 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Sounds good to me, I've applied your suggestion.
>> 
>> I'd appreciate if you could give me some guidance on adding a test for this fix. I may be able fit my reproducer (updated with a 1ms period) into the format of the tests in `jdk.jfr.api.flightrecorder`, but being a periodic test it will require some form of sleep/wait, and be fairly specific to this issue. Please let me know what you think the best path forward is, and I'll put something together :-)
>> 
>> Thanks for your help!
>
>> I'd appreciate if you could give me some guidance on adding a test for this fix.
> 
> It's hard to test in a reliable way. I would not add a test. Time is better spent fixing other issues than hunting down false positives.

Thanks again @egahlin!

> After it has been integrated into main, it can be backported to JDK 21 and 22.

Would you like me to issue the backport commands? I'm not terribly familiar with the process, but I suspect `jdk21u-dev` and `jdk22` are the correct targets?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17114#issuecomment-1875555161


More information about the hotspot-jfr-dev mailing list