RFR: 8279016: JFR Leak Profiler is broken with Shenandoah [v10]
Aleksey Shipilev
shade at openjdk.org
Tue Nov 5 11:10:14 UTC 2024
> While testing unrelated Shenandoah patch, I caught a GC assert when Leak Profiler was running ([JDK-8337194](https://bugs.openjdk.org/browse/JDK-8337194)).
>
> Leak Profiler is notorious in using the mark words for its own needs. We have been trying to mitigate its impact on GCs by moving to separate bitsets for tracking marked objects, or by treating "marked without fwdptr" as "JFR marked" and handling it. But this is not reliable, since things like [putting indexes in mark word](https://github.com/openjdk/jdk/blob/3baff2af6a30cc6cb2e0d4391db1cf7e61c33f64/src/hotspot/share/jfr/leakprofiler/chains/edgeStore.cpp#L275-L280) sneak in. This is okay for Leak Profiler alone, since it restores the mark words after the operation completes, but that is still not enough when GC is already running.
>
> I say we side-step this whack-a-mole by cleanly bailing from JFR op, when we know it is unsafe to do. I thought to use `VM_Operation::doit_prologue`, but I think GC start may sneak in between checking in prologue and op start.
>
> This realistically only affects Shenandoah. All other STW collectors would never see what Leak Profiler did with mark words. ZGC would not see it, since it does not care about mark words for its own operation.
>
> Additional testing:
> - [x] `jdk_jfr` pass by default
> - [x] `jdk_jfr` now passes with `-XX:+UseShenandoah`
Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
Use Shenandoah ProblemLists
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20328/files
- new: https://git.openjdk.org/jdk/pull/20328/files/d47b1665..2d1987b9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20328&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20328&range=08-09
Stats: 115 lines in 34 files changed: 64 ins; 23 del; 28 mod
Patch: https://git.openjdk.org/jdk/pull/20328.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20328/head:pull/20328
PR: https://git.openjdk.org/jdk/pull/20328
More information about the hotspot-jfr-dev
mailing list